Add some utility functions for handling Maxmind geoip results #125153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Elasticsearch 9.0 and above, the minimum JVM version is 21, so we can use new-fangled functions like this.
joegallo
added
:Data Management/Ingest Node
|
Pinging @elastic/es-data-management (Team:Data Management) |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 18, 2025
joegallo
added a commit
to joegallo/elasticsearch
that referenced
this pull request
Mar 19, 2025
smalyshev
pushed a commit
to smalyshev/elasticsearch
that referenced
this pull request
Mar 21, 2025
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a refactoring PR -- we have some repeated blocks of the same logic, so I'm extracting them into utility methods and then using those utility methods.
Note: I can't
auto-backportbecause theHashMap.newHashMap(2)change isn't going to be going back to 8.x (that branch has a minimum java compatible version of 17, so we can't useHashMap.newHashMap(...)which is a 19-ism).